-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TCDS multi-fed support in DAQ and unpacker #30457
Conversation
The code-checks are being triggered in jenkins. |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-30457/16590
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
The code-checks are being triggered in jenkins. |
TCDS unpacker parsing of range of TCDS FEDs. New DataFormats/TCDS class definition to add FED ID from which information was sourced
- with tcds generated by default, unit tests and fake FU scripts require 64 bit event ID and unpacker is included
-code-checks ERROR: Build errors found during clang-tidy run.
|
9341edc
to
dca8b87
Compare
Thanks @smuzaffar! |
+1 |
Comparison job queued. |
Comparison is ready Comparison Summary:
|
+1
(I have not assessed the DAQ-related code in detail, just reco & digi) |
do you have any comments @cms-sw/daq-l2 ? |
+1 @smorovic, sorry for the delay. |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @silviodonato, @dpiparo, @qliphy (and backports should be raised in the release meeting by the corresponding L2) |
No problem, thank you. |
+1 |
PR description:
PR validation:
Tested with new "fakeBU" FED ID generator (incorporated in automated unit test for this module), manually with sample of raw event (file) and in test HLT-like cluster.